Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe fix nextcloud? #405

Merged
merged 6 commits into from
Jan 3, 2024
Merged

maybe fix nextcloud? #405

merged 6 commits into from
Jan 3, 2024

Conversation

drizuid
Copy link
Member

@drizuid drizuid commented Jan 3, 2024

we broke nextcloud with the mjs changes, testing to see if this fixes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-8cff1cf999b7fa3964d14706d6a096c87a143b6c-pr-405/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-8cff1cf999b7fa3964d14706d6a096c87a143b6c-pr-405/shellcheck-result.xml

Tag Passed
amd64-28.0.1-pkg-1497da69-dev-8cff1cf999b7fa3964d14706d6a096c87a143b6c-pr-405
arm64v8-28.0.1-pkg-1497da69-dev-8cff1cf999b7fa3964d14706d6a096c87a143b6c-pr-405

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-760894a4fb334b4029c88b8e40bf85966b99471d-pr-405/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-760894a4fb334b4029c88b8e40bf85966b99471d-pr-405/shellcheck-result.xml

Tag Passed
amd64-28.0.1-pkg-1497da69-dev-760894a4fb334b4029c88b8e40bf85966b99471d-pr-405
arm64v8-28.0.1-pkg-1497da69-dev-760894a4fb334b4029c88b8e40bf85966b99471d-pr-405

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-2d7a5594b78372bbc5af4b01ebc4548adfe6274e-pr-405/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-2d7a5594b78372bbc5af4b01ebc4548adfe6274e-pr-405/shellcheck-result.xml

Tag Passed
amd64-28.0.1-pkg-1497da69-dev-2d7a5594b78372bbc5af4b01ebc4548adfe6274e-pr-405
arm64v8-28.0.1-pkg-1497da69-dev-2d7a5594b78372bbc5af4b01ebc4548adfe6274e-pr-405

@drizuid
Copy link
Member Author

drizuid commented Jan 3, 2024

after testing, i've determined that reverting the mjs changes will fix most things but leave the activity log broken. keeping the mjs changing fix the activity log but break other things. Nothing i've tried resolves both. I also found that for some reason my sed doesn't work as expected and results in a ton of mjs in the string.. doesn't break anything, but causes warning in the logs.
image

im stepping back as I'm out of ideas for now.

I also tested using text/javascript and application/javascript, they do not cause any change at all

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-6b9d8e456a9030a01f43fa7aca7db7cb83f7a447-pr-405/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-6b9d8e456a9030a01f43fa7aca7db7cb83f7a447-pr-405/shellcheck-result.xml

Tag Passed
amd64-28.0.1-pkg-1497da69-dev-6b9d8e456a9030a01f43fa7aca7db7cb83f7a447-pr-405
arm64v8-28.0.1-pkg-1497da69-dev-6b9d8e456a9030a01f43fa7aca7db7cb83f7a447-pr-405

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-4030be827853102c904c898015197f9583a2f5fb-pr-405/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-4030be827853102c904c898015197f9583a2f5fb-pr-405/shellcheck-result.xml

Tag Passed
amd64-28.0.1-pkg-1497da69-dev-4030be827853102c904c898015197f9583a2f5fb-pr-405
arm64v8-28.0.1-pkg-1497da69-dev-4030be827853102c904c898015197f9583a2f5fb-pr-405

@drizuid
Copy link
Member Author

drizuid commented Jan 3, 2024

tested locally and fully functional. had a test from a guy in discord (https://discord.com/channels/354974912613449730/1192093068430675988) experiencing the issues and he tested fully functional
resolves #402 and #403

lspipepr/nextcloud:amd64-28.0.1-pkg-1497da69-dev-4030be827853102c904c898015197f9583a2f5fb-pr-405

@drizuid
Copy link
Member Author

drizuid commented Jan 3, 2024

validations in #402 and in discord. ready for merge

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-ca6cd4b47ecedde586350bba27124a174d9fb14c-pr-405/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.1-pkg-1497da69-dev-ca6cd4b47ecedde586350bba27124a174d9fb14c-pr-405/shellcheck-result.xml

Tag Passed
amd64-28.0.1-pkg-1497da69-dev-ca6cd4b47ecedde586350bba27124a174d9fb14c-pr-405
arm64v8-28.0.1-pkg-1497da69-dev-ca6cd4b47ecedde586350bba27124a174d9fb14c-pr-405

@nemchik nemchik merged commit 360dce0 into master Jan 3, 2024
5 checks passed
@nemchik nemchik deleted the conf-fix-test branch January 3, 2024 23:43
nemchik added a commit that referenced this pull request Jan 3, 2024
drizuid added a commit that referenced this pull request Jan 4, 2024
Merge pull request #405 from linuxserver/conf-fix-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants