-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for trusted user CA keys and authorized principals in OpenSSH config #92
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
Thanks for the PR, but this is way too many env vars added for such a niche feature. Users can easily add this manually as all the necessary files reside in the bind mounted config folder. Each new env var added increases the setup complexity and thus the barrier of entry, and significantly increases the support burden for our team. I'm afraid this PR has a too high cost to benefit ratio. |
all _FILE and ADD_DEFAULT can be removed what about adding 2 env? |
Description:
Add support for trusted user CA keys and authorized principals in OpenSSH config
Benefits of this PR and context:
Add new secure way for ssh keys using CA
How Has This Been Tested?
YES
tested locally
Source / References: