Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for trusted user CA keys and authorized principals in OpenSSH config #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tg123
Copy link

@tg123 tg123 commented Nov 1, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Add support for trusted user CA keys and authorized principals in OpenSSH config

Benefits of this PR and context:

Add new secure way for ssh keys using CA

How Has This Been Tested?

YES

tested locally

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-4908cfe5-dev-9bad6f7ab5350f433539c920bdc7259b6a00680c-pr-92/index.html
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-4908cfe5-dev-9bad6f7ab5350f433539c920bdc7259b6a00680c-pr-92/shellcheck-result.xml

Tag Passed
amd64-9.7_p1-r4-pkg-4908cfe5-dev-9bad6f7ab5350f433539c920bdc7259b6a00680c-pr-92
arm64v8-9.7_p1-r4-pkg-4908cfe5-dev-9bad6f7ab5350f433539c920bdc7259b6a00680c-pr-92

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-4908cfe5-dev-a5b6122a975b819b87aec2f842bb974e80abb01d-pr-92/index.html
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-4908cfe5-dev-a5b6122a975b819b87aec2f842bb974e80abb01d-pr-92/shellcheck-result.xml

Tag Passed
amd64-9.7_p1-r4-pkg-4908cfe5-dev-a5b6122a975b819b87aec2f842bb974e80abb01d-pr-92
arm64v8-9.7_p1-r4-pkg-4908cfe5-dev-a5b6122a975b819b87aec2f842bb974e80abb01d-pr-92

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-dd8ef41c2965b13bdc89fe08414ca2a9f74679fd-pr-92/index.html
https://ci-tests.linuxserver.io/lspipepr/openssh-server/9.7_p1-r4-pkg-9ceb4421-dev-dd8ef41c2965b13bdc89fe08414ca2a9f74679fd-pr-92/shellcheck-result.xml

Tag Passed
amd64-9.7_p1-r4-pkg-9ceb4421-dev-dd8ef41c2965b13bdc89fe08414ca2a9f74679fd-pr-92
arm64v8-9.7_p1-r4-pkg-9ceb4421-dev-dd8ef41c2965b13bdc89fe08414ca2a9f74679fd-pr-92

@aptalca
Copy link
Member

aptalca commented Nov 22, 2024

Thanks for the PR, but this is way too many env vars added for such a niche feature.

Users can easily add this manually as all the necessary files reside in the bind mounted config folder.

Each new env var added increases the setup complexity and thus the barrier of entry, and significantly increases the support burden for our team. I'm afraid this PR has a too high cost to benefit ratio.

@tg123
Copy link
Author

tg123 commented Nov 22, 2024

all _FILE and ADD_DEFAULT can be removed

what about adding 2 env?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants