Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detection #415

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Update detection #415

merged 1 commit into from
Oct 3, 2023

Conversation

Roxedus
Copy link
Member

@Roxedus Roxedus commented Oct 3, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Updates plugin detection to new output introduced in certbot 2.7

Benefits of this PR and context:

Fixes #414

How Has This Been Tested?

Ran wordcount on previous working image, and the current broken one, with the new detection method and got the same output.

Source / References:

@Roxedus Roxedus requested a review from a team October 3, 2023 22:37
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.7.0-pkg-5e0cdeca-dev-49f6fb2b6eef1691264d25b1b9b194ff708144a5-pr-415/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.7.0-pkg-5e0cdeca-dev-49f6fb2b6eef1691264d25b1b9b194ff708144a5-pr-415/shellcheck-result.xml

Tag Passed
amd64-2.7.0-pkg-5e0cdeca-dev-49f6fb2b6eef1691264d25b1b9b194ff708144a5-pr-415
arm64v8-2.7.0-pkg-5e0cdeca-dev-49f6fb2b6eef1691264d25b1b9b194ff708144a5-pr-415

@chipschipschips
Copy link

Confirmed resolves the issue in #414.

@Roxedus Roxedus merged commit 9ba44dc into master Oct 3, 2023
5 checks passed
@Roxedus Roxedus deleted the 2.7-fix branch October 3, 2023 23:33
@Bortus-AI
Copy link

Bortus-AI commented Nov 19, 2023

nvm its working. Started from scratch and good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] 2.7.0 - Please set the DNSPLUGIN variable to one of the following, works reverting to 2.6.0
5 participants