Create internal.conf #520
Open
Create internal.conf #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a single conf file that can be used in proxy-confs via "include /config/nginx/internal.conf" for a single point of management for allowed IPs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
hellblazer315
added a commit
to hellblazer315/docker-mods
that referenced
this pull request
Nov 11, 2024
Changed from explicit IP ranges to using an included config file. Recommend this shouldn't be merged upstream unless linuxserver/docker-swag#520 is as well. Signed-off-by: hellblazer315 <[email protected]>
|
I am a bot, here are the test results for this PR:
|
1 task
|
I am a bot, here is the pushed image/manifest for this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a single conf file that can be used in proxy-confs via "include /config/nginx/internal.conf" for a single point of management for allowed IPs.
EDIT: Completed template.
Description:
Added an internal.conf that specifies common internal IP ranges and tailscale's default range. Blocks access from all other IPs with a 403.
Benefits of this PR and context:
Provides a single place to specify approved IP ranges that may be used across multiple proxy-confs via "include /config/nginx/internal.conf".
How Has This Been Tested?
Yes, had the same snippet within the file in my dashboard.subdomain.conf. Removed that in exchange for "include /config/nginx/internal.conf" and access is still restricted to local IPs.
Source / References:
N/A