Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up init process #521

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Tidy up init process #521

merged 1 commit into from
Nov 16, 2024

Conversation

thespad
Copy link
Member

@thespad thespad commented Nov 16, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

  • Renamed a few steps to clarify that they're part of the swag init and not related to the base - previously we had things like init-permissions on the base and then init-permissions-config in swag, it's now init-swag-permissions.
  • Updated init steps to depend on init-config not init-nginx-end (init-config already depends on init-nginx-end)
  • Removed unnecessary chmod +x for le-renew.sh (it's now +x in the repo)
  • Disabled CI test as we were just fake OKing it as the first init step after the base so it doesn't really test anything

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team November 16, 2024 15:54
@thespad thespad self-assigned this Nov 16, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:3.0.1-pkg-c8ade9f4-dev-ed7c58a4c345a043c3f68ab97986565904a7a142-pr-521

Copy link
Member

@quietsy quietsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thespad thespad merged commit 4437f6f into master Nov 16, 2024
7 checks passed
@thespad thespad deleted the tidy-init branch November 16, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants