-
-
Notifications
You must be signed in to change notification settings - Fork 71
Add support for Mongo TLS & Atlas #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here is the pushed image/manifest for this PR:
|
can please somebody approve and merge this PR. This PR fixes #9 and lots of people are waiting for that ;) |
there's no rush I guess... people waiting can just point to the image mentioned on this comment: #21 (comment) |
I am a bot, here is the pushed image/manifest for this PR:
|
hi, |
Got your point @tobiasfaust. I've updated the PR to set authSource to MONGO_DBNAME by default, and then allow others (e.g. Atlas users) to set it to |
I am a bot, here is the pushed image/manifest for this PR:
|
hi @mkrle, it works perfectly right now.
|
That |
root/etc/s6-overlay/s6-rc.d/init-unifi-network-application-config/run
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry to the changelog in the readme summarising the changes.
Done. Also squashed the commits as they were growing in number. Thanks a lot for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the changelog fix looks fine and I'll be happy to approve it.
… new MongoDB versions
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
Description:
I have added flags for TLS (
tls
) andauthSource
to the MongoDB URLs. The TLS flag is set to true depending on theMONGO_TLS
variable.authSource
is always set toadmin
.Benefits of this PR and context:
This PR will do the following:
defaultauthdb
parameterHow Has This Been Tested?
I have tested with not defining MONGO_TLS variable and haven't noticed any change in behaviour. It would be good if we could get more volunteers to test.
My test environment was linux (arm64) docker with Atlas as MongoDB backend.
Source / References:
https://www.mongodb.com/docs/v4.4/reference/connection-string/
https://stackoverflow.com/questions/38237663/mongo-atlas-connection-authentication-failed-with-custom-databases