Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace placeholers in properties with envsubst #72

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Replace placeholers in properties with envsubst #72

wants to merge 18 commits into from

Conversation

sturman
Copy link
Contributor

@sturman sturman commented Feb 24, 2024

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Use envsubst tool to replace placeholders in system.properties file

Benefits of this PR and context:

  • less environment variables are required. No need to specify MONGO_AUTHSOURCE, MONGO_TLS etc
  • possibility to set any MongoDB URL e.g. mongo://user:pass@localhost:27017/my-unifi-db?option=value or for MongoDB Atlasmongodb+srv://unifi-user:[email protected]/unifi?retryWrites=true&w=majority&appName=unifi
  • possibility to use MongoDB Atlas

Cons: no check if MongoDB is alive.

How Has This Been Tested?

Tested with the following steps on MacOS 14 (Intel):

  1. create free MongoDB Atlas instance.
  2. create a database user with read+write permissions to any DB in the cluster
  3. docker build -t unifi .
  4. docker run --name unifi -p 8443:8443 -e MONGO_URI="mongodb+srv://unifi:[email protected]/unifi?retryWrites=true&w=majority&appName=unifi" -e STAT_MONGO_URI="mongodb+srv://unifi:[email protected]/unifi-stats?retryWrites=true&w=majority&appName=unifi" -e MONGO_DBNAME=unifi unifi
  5. open https://0.0.0.0:8443/setup/ in browser
  6. check if both unifi and unifi_stat DBs are created in MongoDB cluster

Source / References:

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.0.28-pkg-aabd36c7-dev-3be04fb26202945d1944776df234367dadb9843e-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.0.28-pkg-aabd36c7-dev-27594b95a8141a912c1b3832c6262cf273f2b0e4-pr-72

@sturman sturman marked this pull request as ready for review March 20, 2024 10:27
@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.113-pkg-f2d4d5b2-dev-41b367182a15e42562f68e375adabc34d356c30c-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.113-pkg-f2d4d5b2-dev-1a538030bef5f675b12fffe175c4e2e51f9b1275-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.113-pkg-6d1565cd-dev-73b5e6e516ef7efb5afb31619160b095f24eab7d-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.113-pkg-5794ab45-dev-f1d258be6cdb84ce3c2697313f4f39dc125366fd-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.127-pkg-4c41fbf8-dev-9f8030f07a5da87034e818fd94354ac1bd979183-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.127-pkg-45c5b9a8-dev-6c66615f28a83a0905727730795151a37e43bf75-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.1.127-pkg-45c5b9a8-dev-96d3003d43e18732af28a5df9c6a1c99b842fff6-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.2.93-pkg-8a06939b-dev-4ea124f871718776de8daff371f144a4c6fb9ab5-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.2.93-pkg-a3865b8a-dev-193fd99ab294de94ecf11abd2595240dd91eee8c-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.2.93-pkg-b6d1f908-dev-fa931ac14b7d4873d015c1b36fa0498135a40aab-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.3.32-pkg-7084b29b-dev-76bcaf322d46b4bcedd049d05224ab131c7494e1-pr-72

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@sturman
Merge remote-tracking branch 'origin/main' into replace-placeholers-i…
61c4b50 
…n-proeprties

# Conflicts:
#	README.md
#	readme-vars.yml
@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.3.32-pkg-1e1f6820-dev-61c4b501a0616ce23944d6a1b2ba7a46edee6acd-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.4.59-pkg-427faa56-dev-a60a8bd34fc82a623002792b47eb6a847c94c544-pr-72

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.4.62-pkg-fae37f7b-dev-7654109ffa4f1806763af04500ee1067c9ba4e23-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.5.6-pkg-ee14e0ab-dev-3c43dd6cd850e4ff8776eb83013f194a72b7837e-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.5.6-pkg-27082a08-dev-b5bc44f80612852fc86cba4e4c0ff7c59d40c429-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.6.9-pkg-27082a08-dev-0aa4543e91d4949b49f1a94e720d11f1ca8fb7e9-pr-72

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-unifi-network-application:8.6.9-pkg-49c171f2-dev-83043fab98c72b4e53ded8b64b3121ff21de5eed-pr-72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Issue & PR Tracker
Status: PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sturman @LinuxServer-CI