feat: support websockify behind a proxy #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the whole nodejs server is behind a proxy like nginx, this change makes the websockify work well. For example, a request is sent to `http://exmaple.com/myvnc`, nginx rewrites the path from `/myvnc` to `/`, then proxy-passes the request to localhost:6900. Previously, `vnc/index.html` wrongly tries to connect `ws://example.com/websockify`, which is forbidden by the nginx. After setting `PRE_PATH` to `/myvnc/`, the URL is `ws://example.com/myvnc/websockify`, then can be processed by nginx. If the whole nodejs server is not behind a proxy, without setting `PRE_PATH`, the `index.js` behaves like before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the whole nodejs server is behind a proxy like nginx, this change makes the websockify work well. For example, a request is sent to
http://exmaple.com/myvnc, nginx rewrites the path from/myvncto/, then proxy-passes the request to localhost:6900. Previously,vnc/index.htmlwrongly tries to connectws://example.com/websockify, which is forbidden by the nginx. After settingPRE_PATHto/myvnc/, the URL isws://example.com/myvnc/websockify, then can be processed by nginx. If the whole nodejs server is not behind a proxy, without settingPRE_PATH, theindex.jsbehaves like before.