Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support customized defined className #465

Merged

Conversation

flying3615
Copy link
Contributor

@flying3615 flying3615 commented Jun 13, 2024

Fix for supporting customized className in GridFormDropDown.tsx

Issue happens in VectorPanel, it has a customized className, but GridCell default className GridPopoverEditDropDown-containerLarge was override by it, so move it to the last line in the editorParams to avoid override

SURVEY-24640

[B] CSD ref field in Vectors panel is missing scroll bar

Author Checklist

  • appropriate description or links provided to provide context on the PR
  • self reviewed, seems easy to understand and follow
  • reasonable code test coverage
  • change is documented in Storybook and/or markdown files

Reviewer Checklist

  • Follows convention
  • Does what the author says it will do
  • Does not appear to cause side effects and breaking changes
    • if it does cause breaking changes, those are appropriately referenced

Post merge

  • Post about the change in #lui-cop

Conventional Commit Cheat Sheet:
build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
ci: Changes to our CI configuration files and scripts (example scopes: Circle, BrowserStack, SauceLabs)
docs: Documentation only changes
feat: A new feature
fix: A bug fix
perf: A code change that improves performance
refactor: A code change that neither fixes a bug nor adds a feature
test: Adding missing tests or correcting existing tests

@flying3615 flying3615 merged commit 64267b3 into master Jun 13, 2024
7 checks passed
@flying3615 flying3615 deleted the fix/SURVEY-24640-vector-panel-csd-missing-scrollbar branch June 13, 2024 22:08
Copy link

🎉 This PR is included in version 21.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants