Skip to content

Fix CI action pinning policy violation - #5

Merged
lioneldyla merged 1 commit into
codex/advanced-rag-contractsfrom
fix/ci-pin-actions
Jun 30, 2026
Merged

Fix CI action pinning policy violation#5
lioneldyla merged 1 commit into
codex/advanced-rag-contractsfrom
fix/ci-pin-actions

Conversation

@lioneldyla

@lioneldyla lioneldyla commented Jun 30, 2026

Copy link
Copy Markdown
Owner

This PR pins the CI workflow actions to full commit SHAs so the validate job can pass repository policy checks.

Summary by Sourcery

Pin CI workflow actions to specific commit SHAs and simplify test step environment configuration.

CI:

  • Pin GitHub Actions (checkout, setup-python, setup-uv) to full commit SHAs to comply with repository policy checks.
  • Remove unused secret environment variables from the test execution step in the CI workflow.

@sourcery-ai

sourcery-ai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins all GitHub Actions in the CI workflow to specific commit SHAs to satisfy action pinning policies and removes unused secret environment variables from the test step.

File-Level Changes

Change Details Files
Pin CI workflow GitHub Actions to specific commit SHAs to comply with security policy.
  • Replaced actions/checkout version tag with a full commit SHA corresponding to v7.0.0.
  • Replaced actions/setup-python version tag with a full commit SHA corresponding to v6.3.0.
  • Replaced astral-sh/setup-uv version tag with a full commit SHA corresponding to v8.2.0.
  • Annotated each pinned action with the corresponding semantic version comment for readability.
.github/workflows/ci.yml
Simplify test step environment by removing API key secrets from CI job.
  • Removed OPENAI_API_KEY, GROQ_API_KEY, and QDRANT_API_KEY environment variables from the "Run tests" step.
  • Ensured pytest invocation remains unchanged so test behavior is unaffected aside from missing env vars.
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the actions are now pinned to specific SHAs, consider adding a brief note or reference in the workflow (or a central place) about how and when to update these pins so they don’t silently drift out-of-date over time.
  • You removed the OPENAI/GROQ/QDRANT env vars from the test step; if any tests still depend on external APIs, consider reintroducing them in a more tightly scoped way (e.g., only for specific jobs or steps) rather than globally or not at all.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the actions are now pinned to specific SHAs, consider adding a brief note or reference in the workflow (or a central place) about how and when to update these pins so they don’t silently drift out-of-date over time.
- You removed the OPENAI/GROQ/QDRANT env vars from the test step; if any tests still depend on external APIs, consider reintroducing them in a more tightly scoped way (e.g., only for specific jobs or steps) rather than globally or not at all.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lioneldyla lioneldyla closed this Jun 30, 2026
@lioneldyla lioneldyla reopened this Jun 30, 2026
@lioneldyla
lioneldyla merged commit 342ce6a into codex/advanced-rag-contracts Jun 30, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant