Skip to content

Track Simplification Pass Names #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcosta358 merged 3 commits into from
Jul 20, 2026
Merged

Track Simplification Pass Names #265

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5aaf6f
Track Simplification Pass Names
rcosta358 Jun 22, 2026
6aa3a40
Minor Change
rcosta358 Jun 23, 2026
5961776
Remove `Objects.requireNonNull()`
rcosta358 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion liquidjava-verifier/src/main/java/liquidjava/rj_language/opt/VCSimplification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ public static VCSimplificationResult simplifyOnce(VCSimplificationResult implica
VCImplication simplified = pass.apply(implication.getImplication());
if (implication.getImplication().equals(simplified))
return implication;
return new VCSimplificationResult(simplified, implication);
return new VCSimplificationResult(simplified, implication, pass.getName());
}
}
5 changes: 5 additions & 0 deletions liquidjava-verifier/src/main/java/liquidjava/rj_language/opt/VCSimplificationPass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,9 @@
*/
public interface VCSimplificationPass {
VCImplication apply(VCImplication implication);

default String getName() {
return getClass().getSimpleName().replaceFirst("^VC", "").replaceFirst("Simplification$", "")
.replaceAll("(?<=[a-z0-9])(?=[A-Z])", " ");
}
}
17 changes: 14 additions & 3 deletions liquidjava-verifier/src/main/java/liquidjava/rj_language/opt/VCSimplificationResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,18 @@ public final class VCSimplificationResult {

private final VCImplication implication;
private final VCSimplificationResult origin;
private final String simplification;

public VCSimplificationResult(VCImplication implication) {
this(implication, null);
this.implication = Objects.requireNonNull(implication).clone();

@CatarinaGamboa CatarinaGamboa Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use this "requireNonNull" in several places across the codebase? I was under the impression we didn't use that as a standard

@rcosta358 rcosta358 Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we don't, I'll remove it.

this.origin = null;
this.simplification = null;
}

public VCSimplificationResult(VCImplication implication, VCSimplificationResult origin) {
public VCSimplificationResult(VCImplication implication, VCSimplificationResult origin, String simplification) {
this.implication = Objects.requireNonNull(implication).clone();
this.origin = origin;
this.origin = Objects.requireNonNull(origin);
this.simplification = Objects.requireNonNull(simplification);
}

/**
Expand All @@ -35,6 +39,13 @@ public VCSimplificationResult getOrigin() {
return origin;
}

/**
* Returns the name of the simplification pass that produced this result or null for the original VC chain
*/
public String getSimplification() {
return simplification;
}

@Override
public String toString() {
if (origin == null)
Expand Down
Loading