Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 1.14.4 and 1.15 support #236

Closed
wants to merge 43 commits into from
Closed

Added 1.14.4 and 1.15 support #236

wants to merge 43 commits into from

Conversation

NgLoader
Copy link

@NgLoader NgLoader commented Sep 4, 2019 •
edited
Loading

Currently finished

@NgLoader NgLoader mentioned this pull request Sep 4, 2019
Open
@ProgrammerDan
Copy link
Collaborator

ProgrammerDan commented Sep 4, 2019 via email

@ProgrammerDan
Copy link
Collaborator

Broad strokes are OK, some details to fine tune -- do you figure you are done with this contribution or do you intend to work on it more? Regardless, thanks for this contribution, will blend with the prior PR, alongside some additional work I intend to begin soon to figure out the longstanding bugs.

ProgrammerDan
ProgrammerDan requested changes Sep 5, 2019
View reviewed changes
Copy link
Collaborator

@ProgrammerDan ProgrammerDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, some stuff to double check -- thanks for contributing!

@NgLoader
Copy link
Author

NgLoader commented Sep 5, 2019

I commit some changes soon 👍

@NgLoader
Copy link
Author

NgLoader commented Sep 5, 2019

Currently I'm looking into the ArrayIndexOutOfBoundsException error

This was referenced Sep 5, 2019
Open
Open
@ProgrammerDan
Copy link
Collaborator

Any updates here, friend?

@Chevels
Copy link

Chevels commented Nov 11, 2019

Any news ? Or OFC is definitively abandonned ? :/

@ProgrammerDan
Copy link
Collaborator

Nothing new from the contributor of this PR, and as for me I haven't had much time for any of my projects. Not officially abandoned but I would welcome dedicated help.

@SydMontague
Copy link

I tested the branch locally and it didn't work properly. After some digging I figured out it's because of a protocol change the code doesn't attribute for.
(In detail: light information is not transmitted anymore and a non-air block count field has been introduced)

Based on NgLoader's work I wrote a patch that should make it 1.14.4 compatible, it worked on my local test server but that by no means indicates full compatibility. The patch shouldn't be backward compatible either, so for that some more work is required.

Orebfuscator114.patch.txt

@ProgrammerDan
Copy link
Collaborator

ProgrammerDan commented Nov 21, 2019 via email

@NgLoader
Copy link
Author

I commit some changes soon.
Currently is my pc away for a upgrade.

Thanks @SydMontague

@NgLoader
Copy link
Author

And @SydMontague you can commit on my frok so you don't need to send a txt file with changes 😅

@NgLoader
Copy link
Author

I moved the project to a new location
Repo

@SydMontague
Improved 1.14.4 compatibility
89d7177 
- removed reflection from NmsManager, since it was only for 1.13.2
- added null check to BlockUpdate, since it's nullable
- use blockCount field when using 1.14.4
- don't use lightingArray when using 1.14.4

This should be backwards compatible (tested with 1.13.2).
@SydMontague
Copy link

I created a pull request to your repo and also fixed some more issues. The NmsManager did some obsolete reflection that caused the plugin to not work properly in the Nether. In the process I also found a potential NPE I prevented with a simple null check.

The changes I made should now also be backwards compatible...

@NgLoader
Copy link
Author

NgLoader commented Dec 8, 2019 •
edited
Loading

Its working for me too, you can test the version here

I'm currently finished
Some small updates coming soon

NgLoader and others added 3 commits December 10, 2019 00:16
@NgLoader NgLoader changed the title Added 1.14.4 R0.1 support Added 1.14.4 and 1.15 support Dec 15, 2019
@NgLoader NgLoader closed this Dec 29, 2019
@Miky88
Copy link

Miky88 commented Jun 26, 2020

rip why closed

@NgLoader
Copy link
Author

The project was moved to Imprex-Development for 1.8-1.15 support.
1.16 ist currently in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProgrammerDan ProgrammerDan Awaiting requested review from ProgrammerDan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NgLoader @ProgrammerDan @Chevels @SydMontague @Miky88 @team-wuffy