Impro #106
Merged
Impro #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisitsyn
approved these changes
May 24, 2024
lisitsyn
reviewed
May 24, 2024
README.md
Outdated
| @@ -130,8 +125,7 @@ A minimal working example of a program that uses the library is: | |||
|
|
|||
| MyDistanceCallback d; | |||
|
|
|||
| TapkeeOutput output = tapkee::initialize() | |||
| .withParameters((method=MultidimensionalScaling,target_dimension=1)) | |||
| TapkeeOutput output = tapke::with((method=MultidimensionalScaling,target_dimension=1)) | |||
There was a problem hiding this comment.
Is it the indentation? In that case, yeah I see that maybe this line is a bit longer than the other ones with code (here in the inline diff it looks like a new line, while it is only one). Any option looks good to me, like it is with the long-ish line, or, alternatively, finishing this line at = and aligning the tapkee::with with the other with* below.
I tried but didn't manage to find a typo in the names in this line ':-D
There was a problem hiding this comment.
Ah, finally see it, thank you!
|
I checked there were no other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally
ctestwas fine, let's see in the CI and I will take a look at examples.