-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix npm run lint on Windows #25
base: main
Are you sure you want to change the base?
Conversation
`npm run lint` fails because eslint does not like the `'`s wrapping its target path. Removing the single quotes fixes `npm run lint`
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Why doesn't work for you with the |
It may be an environment thing, certainly running |
I've just confirmed this is only an issue on my Windows rig, on my Mac all is well |
The fix in this PR is compatible with both of my machines, but I'll leave this to your discretion |
Got it, you are right! Windows issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this, should work both!
Add <xliff> element, remove prettier formatting, release
Should I close this PR? |
npm run lint
fails because eslint does not like the'
s wrapping its target path. Removing the single quotes fixesnpm run lint