-
-
Notifications
You must be signed in to change notification settings - Fork 465
fix(PydanticDTO): enforce explicit specification for Optional fields and ensure default factory usage for list fields #4236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewsapw
wants to merge
9
commits into
litestar-org:main
Choose a base branch
from
andrewsapw:fix/optional-dto-field
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+37
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4236 +/- ##
==========================================
- Coverage 98.38% 98.38% -0.01%
==========================================
Files 348 348
Lines 15895 15891 -4
Branches 1756 1754 -2
==========================================
- Hits 15638 15634 -4
Misses 121 121
Partials 136 136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optional
and without default value or default factory - it still must be explicitly specifiedlist
and has default factory - default factory must be used when initializing model without providing value for this fieldAlso, fixed
test_field_definition_implicit_optional_default
test, that checked ifOptional
field without default / default_factory converts to field withNone
as default value, although similar msgspec model converts it to field withEmpty
valueCloses
Partially closes #4232