Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for net8 Lambda Run Time #123

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"name": "HeadlessChromium.Puppeteer.Lambda.Dotnet",
"version": "0.0.1-dev",
"dependencies": {
"@sparticuz/chromium": "123.0.0"
"@sparticuz/chromium": "123.0.1"
}
}
7 changes: 6 additions & 1 deletion sample/SampleLambda-dotnet8/HelloWorldHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ public async Task<byte[]> Handle(ILambdaContext context)
var loggerFactory = LoggerFactory.Create(builder => builder.AddConsole());
var browserLauncher = new HeadlessChromiumPuppeteerLauncher(loggerFactory);

await using (var browser = await browserLauncher.LaunchAsync())
var launchArgs = HeadlessChromiumPuppeteerLauncher.DefaultChromeArgs
.Append("--enable-logging")
.Append("--v=1")
.ToArray();

await using (var browser = await browserLauncher.LaunchAsync(launchArgs))
await using (var page = await browser.NewPageAsync())
{
await page.GoToAsync("https://www.google.com");
Expand Down
2 changes: 1 addition & 1 deletion sample/SampleLambda-dotnet8/SampleLambda.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<PackageReference Include="Amazon.Lambda.Serialization.Json" Version="2.1.1" />
<PackageReference Include="HeadlessChromium.Puppeteer.Lambda.Dotnet" Version="1.1.0-dev" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="6.0.0" />
<PackageReference Include="PuppeteerSharp" Version="13.0.1" />
<PackageReference Include="PuppeteerSharp" Version="18.0.2" />
</ItemGroup>

</Project>
Loading