.NET 8 support #136
Merged
.NET 8 support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianfeucht
approved these changes
Jul 15, 2024
|
This is fantastic @LouisMT Thank you for the work and the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the
SampleLambda-dotnet8project locally, I noticed some warnings/errors regarding fonts.I then compared the contents of the
public.ecr.aws/lambda/dotnet:8Docker image to thepublic.ecr.aws/lambda/dotnet:6image, and apparently the AL2 based image contains some fonts and also a lot of fontconfigs, while the AL2023 based image does not. When copying over the fonts from the AL2 based image to the AL2023 based image, the tests are passing (and the resulting PNG is also looking good imo).Then I noticed the npm package also contains a
fonts.tar.brfile. By extracting it along with the other dependencies, copying over the fonts from the AL2 based image isn't needed anymore; the tests are still passing.I haven't been able to test on an actual Lambda, but hopefully this will help.