Fix Incomplete multi-character sanitization in stripHtml function

littlefoxcompany · May 15, 2024 · 23fc860 · 23fc860
1 parent 5dccf23
commit 23fc860
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/modifiers.test.ts b/src/modifiers.test.ts
@@ -3,6 +3,7 @@ import * as mod from './modifiers'
 
 test('stripHtml', () => {
   expect(mod.stripHtml('<p>Hello world</p>')).toBe('Hello world')
+  expect(mod.stripHtml('<script>Hello world</script>')).toBe('Hello world')
 })
 
 test('escapeHtml', () => {

diff --git a/src/modifiers.ts b/src/modifiers.ts
@@ -156,7 +156,7 @@ export function ordinalize(value: number): string {
  * Strip HTML tags from a string.
  */
 export function stripHtml(text: string): string {
-  return text.replace(/<[^>]*>/gm, '')
+  return text.replace(/<\/?[^>]+(>|$)/g, '')
 }
 
 /**