Fix issue when using dictionary function #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously after the function was evaluated the rest of the loop merging the dicts containing the descriptions continued using V instead of the return value of the function. That could probably cause multiple issues, but the one guaranteed issue was when the returned dictionary contained only plain descriptions and no function (plain string instead of list). If you are using a dictionary function and see single-letter-descriptions where the letter is the second letter of the description, this probably fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, after the function was evaluated, the rest of the loop merging the dicts containing the descriptions continued using V instead of the return value of the function.
That could probably cause multiple issues, but the one guaranteed issue was when the returned dictionary contained only plain descriptions and no function (plain string instead of list).
If you are using a dictionary function and see
single-letter-descriptions where the letter is the second letter of the description, this probably fixes it.
I'm using this fix myself, but I'm open to other ways of solving this issue.