Refactor auth config #2650
Merged
Refactor auth config #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
jonatanklosko
commented
Jun 14, 2024
Comment on lines
29
to
-34
| def authenticate(conn, %{"password" => password}) do | ||
| conn = AuthPlug.store(conn, :password, password) | ||
|
|
||
| if AuthPlug.authenticated?(conn, :password) do |
There was a problem hiding this comment.
We used to pass :password here explicitly and compare that it matches with the configured mode. I don't think it's necessary though. We have a controller plug that ensures the user is not already authenticated, so the only way they become authenticated here is if the submitted password is valid and the mode is actually password.
josevalim
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently auth is controlled by several configuration keys, namely
:authentication_mode,:password,:token. I moved it to a single:authenticationkey. For:tokenwe use a persistent term to generate and cache a random value. I also simplified the auth code a bit.