Merge pull request #120 from livechat/Fix_customer_api_ver_36

Added support for CustomerRtmV36 in the get_client method for API ver…
livechat · Dec 1, 2023 · 10b1aad · 10b1aad
2 parents eef9476 + 601e3d9
commit 10b1aad
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 7 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,6 +1,12 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [0.3.9] - XXX
+
+### Bugfixes
+- Enabled instantiation for `CustomerRtmV36` within the 3.6 version of the Customer RTM API.
+- Adjusted the return types in `get_client` method across RTM and WEB clients.
+
 ## [0.3.8] - 2023-11-30
 
 ### Added

diff --git a/livechat/agent/rtm/base.py b/livechat/agent/rtm/base.py
@@ -21,7 +21,7 @@ class AgentRTM:
     def get_client(
         version: str = stable_version,
         base_url: str = api_url
-    ) -> Union[AgentRtmV33, AgentRtmV34, AgentRtmV35]:
+    ) -> Union[AgentRtmV33, AgentRtmV34, AgentRtmV35, AgentRtmV36]:
         ''' Returns client for specific Agent RTM version.
 
             Args:

diff --git a/livechat/agent/web/base.py b/livechat/agent/web/base.py
@@ -27,7 +27,7 @@ def get_client(
         proxies: dict = None,
         verify: bool = True,
         disable_logging: bool = False,
-    ) -> Union[AgentWebV33, AgentWebV34, AgentWebV35]:
+    ) -> Union[AgentWebV33, AgentWebV34, AgentWebV35, AgentWebV36]:
         ''' Returns client for specific API version.
 
             Args:

diff --git a/livechat/configuration/base.py b/livechat/configuration/base.py
@@ -28,7 +28,8 @@ def get_client(
         proxies: dict = None,
         verify: bool = True,
         disable_logging: bool = False,
-    ) -> Union[ConfigurationApiV33, ConfigurationApiV34, ConfigurationApiV35]:
+    ) -> Union[ConfigurationApiV33, ConfigurationApiV34, ConfigurationApiV35,
+               ConfigurationApiV36]:
         ''' Returns client for specific Configuration API version.
 
             Args:

diff --git a/livechat/customer/rtm/base.py b/livechat/customer/rtm/base.py
@@ -8,6 +8,7 @@
 from livechat.customer.rtm.api.v33 import CustomerRtmV33
 from livechat.customer.rtm.api.v34 import CustomerRtmV34
 from livechat.customer.rtm.api.v35 import CustomerRtmV35
+from livechat.customer.rtm.api.v36 import CustomerRtmV36
 
 stable_version = CONFIG.get('stable')
 api_url = CONFIG.get('url')
@@ -21,7 +22,7 @@ def get_client(
         base_url: str = api_url,
         license_id: int = None,
         organization_id: str = None
-    ) -> Union[CustomerRtmV33, CustomerRtmV34, CustomerRtmV35]:
+    ) -> Union[CustomerRtmV33, CustomerRtmV34, CustomerRtmV35, CustomerRtmV36]:
         ''' Returns client for specific Customer RTM version.
 
             Args:
@@ -40,7 +41,7 @@ def get_client(
             '3.3': CustomerRtmV33,
             '3.4': CustomerRtmV34,
             '3.5': CustomerRtmV35,
-            '3.6': CustomerRtmV35,
+            '3.6': CustomerRtmV36,
         }.get(version)
         client_kwargs = {
             '3.3': {

diff --git a/livechat/customer/web/base.py b/livechat/customer/web/base.py
@@ -30,7 +30,7 @@ def get_client(
         verify: bool = True,
         organization_id: str = None,
         disable_logging: bool = False,
-    ) -> Union[CustomerWebV33, CustomerWebV34, CustomerWebV35]:
+    ) -> Union[CustomerWebV33, CustomerWebV34, CustomerWebV35, CustomerWebV36]:
         ''' Returns client for specific API version.
 
             Args:

diff --git a/livechat/reports/base.py b/livechat/reports/base.py
@@ -29,7 +29,7 @@ def get_client(
         proxies: dict = None,
         verify: bool = True,
         disable_logging: bool = False,
-    ) -> Union[ReportsApiV33, ReportsApiV34, ReportsApiV35]:
+    ) -> Union[ReportsApiV33, ReportsApiV34, ReportsApiV35, ReportsApiV36]:
         ''' Returns client for specific Reports API version.
 
             Args: