Exposed response_timeout parameter in open_connection methods #138
Conversation
changelog.md
Outdated
| @@ -8,6 +8,8 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| ### Changed | |||
| - Updated outdated packages. | |||
| - Exposed `response_timeout` parameter in `open_connection` methods. | |||
There was a problem hiding this comment.
"Exposed" indicates that it was already present but hidden. I'd consider moving it to "Added" section and rephrasing to:
"Added
response_timeoutparameter inopen_connectionmethods."
There was a problem hiding this comment.
According to Cambridge Dictionary: "expose: to make something covered or hidden able to seen". Well, I would say that response_timeout was somewhere available in the code but covered by the encapsulation within the structure of the SDK. Anyway, it is all the same to me, so I will apply your suggestion.
livechat/agent/rtm/api/v33.py
Outdated
| ping_interval: float = 5, | ||
| ws_conn_timeout: float = 10, | ||
| keep_alive: bool = True) -> None: | ||
| keep_alive: bool = True, | ||
| response_timeout: float = 3) -> None: |
There was a problem hiding this comment.
It seems strange to me that all values have the type marked as float and the default value as int. Since we are making changes in this area, I would consider changing all types to:
| response_timeout: float = 3) -> None: | |
| response_timeout: Union[float, int] = 3) -> None: |
considering (int or float) in the docstring for response_timeout arg and https://websocket-client.readthedocs.io/en/latest/app.html#websocket._app.WebSocketApp.run_forever
ping_interval (int or float), ping_timeout (int or float)
ws_conn_timeout should stay as float with 10.0 as default value.
There was a problem hiding this comment.
Therefore I have chosen float to be consistent with others. Anyway, I will change all types to Union[ float, int].
marcindebski
deleted the
Expose_response_timeout_in_open_connection_method
branch
No description provided.