brianyin/ajs-310-play-local-audio-file-utility #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2d6774 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
toubatbrian
changed the title
toubatbrian
commented
Oct 27, 2025
agents/src/codecs/utils.ts
Outdated
Comment on lines
51
to
59
| '-probesize', | ||
| '32', | ||
| '-analyzeduration', | ||
| '0', | ||
| '-fflags', | ||
| '+nobuffer+flush_packets', | ||
| '-flags', | ||
| 'low_delay', | ||
| ]) |
There was a problem hiding this comment.
same set of flags as in python
toubatbrian
commented
Oct 27, 2025
Comment on lines
+130
to
+141
| it('should gracefully handle close while read is pending', async () => { | ||
| const channel = createStreamChannel<string>(); | ||
| const reader = channel.stream().getReader(); | ||
|
|
||
| const readPromise = reader.read(); | ||
|
|
||
| await channel.close(); | ||
|
|
||
| const result = await readPromise; | ||
| expect(result.done).toBe(true); | ||
| expect(result.value).toBeUndefined(); | ||
| }); |
There was a problem hiding this comment.
add tests to make sure buffered read after close still reads correct values
toubatbrian
commented
Oct 27, 2025
Comment on lines
45
to
57
| for await (const frame of codecs.loopAudioFramesFromFile(audioFile, { | ||
| sampleRate: 48000, | ||
| numChannels: 1, | ||
| abortSignal: abortController.signal, | ||
| })) { | ||
| await audioSource.captureFrame(frame); | ||
| frameCount++; | ||
|
|
||
| if (frameCount % 100 === 0) { | ||
| logger.info(`Played ${frameCount} frames (${(frameCount * 0.1).toFixed(1)}s)`); | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
example of directly playing an audio file on server side and send to livekit.
toubatbrian
commented
Oct 27, 2025
Comment on lines
+120
to
+129
| .inputOptions([ | ||
| '-probesize', | ||
| '32', | ||
| '-analyzeduration', | ||
| '0', | ||
| '-fflags', | ||
| '+nobuffer+flush_packets', | ||
| '-flags', | ||
| 'low_delay', | ||
| ]) |
There was a problem hiding this comment.
same flags as in python
There was a problem hiding this comment.
when the generator closes, where do we close the ffmpeg process?
theomonnom
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility to play a local audio file.
This is a dependency of
BackgroundAudioplayer