Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_response and cancel_response APIs for MultimodalAgent #1359

Merged
merged 12 commits into from
Jan 18, 2025

Conversation

longcw
Copy link
Collaborator

@longcw longcw commented Jan 10, 2025

Created a push-to-talk example for the manual VAD of OAI realtime api.

A follow up of #1347

Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: ee14d48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@longcw longcw requested a review from a team January 10, 2025 10:40
@lukasIO
Copy link
Contributor

lukasIO commented Jan 10, 2025

just my 2c, but would be nice if this was using @bcherry's RPC feature via LiveKit, instead of a custom WebSocket ?

@longcw
Copy link
Collaborator Author

longcw commented Jan 10, 2025

just my 2c, but would be nice if this was using @bcherry's RPC feature via LiveKit, instead of a custom WebSocket ?

The frontend in the example is just a simple button without a full livekit client. What is the simplest way to incorporate the RPC in a single web page or do we want to add a full client in the example. Or mention to use RPC for a real production in readme and comments?

@longcw
Copy link
Collaborator Author

longcw commented Jan 11, 2025

@lukasIO @davidzhao updated to use RPC with frontend example livekit-examples/voice-assistant-frontend#23

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longcw since the frontend will take awhile, can we push the multimodal_agent changes in first, without the PTT example?

@longcw
Copy link
Collaborator Author

longcw commented Jan 15, 2025

@longcw since the frontend will take awhile, can we push the multimodal_agent changes in first, without the PTT example?

sounds good. how about we keep the example but just mention how should it work in readme without a link to the frontend.

@davidzhao davidzhao changed the title create a push to talk example for OAI realtime api create_response and cancel_response APIs for MultimodalAgent Jan 18, 2025
@longcw longcw merged commit 1f6b457 into main Jan 18, 2025
14 checks passed
@longcw longcw deleted the longc/push-to-talk-example branch January 18, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants