Shubhra/nvidia plugins #3392
Open
Shubhra/nvidia plugins #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
riqiang-dp
reviewed
Sep 18, 2025
|
|
||
| try: | ||
| await asyncio.gather(*tasks) | ||
| await asyncio.to_thread(synthesize_thread.join, timeout=5.0) |
There was a problem hiding this comment.
Hi, I just got a chance to test this, but this timeout is causing TTS to be cut off before finishing long sentences (>5s) Is this working properly for you? I set it to 20 and everything works as expected.
|
|
||
| self._auth = riva.client.Auth( | ||
| uri=stt._opts.server, | ||
| use_ssl=True, |
There was a problem hiding this comment.
it would be nice to have the option to set it to False (for local deployment and testing)
| if not self._tts_service: | ||
| auth = riva.client.Auth( | ||
| uri=self._opts.server, | ||
| use_ssl=True, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try it out with
uv run examples/voice_agents/nvidia_test.py console