Skip to content

ignore agent context on generate_reply if flag is set #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ignore agent context on generate_reply if flag is set #3534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd9cb25
ignore agent context on generate_reply if flag is set
s-hamdananwar Sep 29, 2025
a2288aa
ruff fix
s-hamdananwar Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions livekit-agents/livekit/agents/voice/agent_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,17 +777,25 @@ def _generate_reply(
tool_choice: NotGivenOr[llm.ToolChoice] = NOT_GIVEN,
allow_interruptions: NotGivenOr[bool] = NOT_GIVEN,
schedule_speech: bool = True,
ignore_agent_instructions: bool = False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if ignore_agent_instructions is the right API to add.

Maybe we can just allow to pass-in a custom chat_ctx?

) -> SpeechHandle:
if (
isinstance(self.llm, llm.RealtimeModel)
and self.llm.capabilities.turn_detection
and allow_interruptions is False
):
logger.warning(
"the RealtimeModel uses a server-side turn detection, allow_interruptions cannot be False when using VoiceAgent.generate_reply(), " # noqa: E501
"disable turn_detection in the RealtimeModel and use VAD on the AgentTask/VoiceAgent instead" # noqa: E501
)
allow_interruptions = NOT_GIVEN
if (
self.llm.capabilities.turn_detection
and allow_interruptions is False
):
logger.warning(
"the RealtimeModel uses a server-side turn detection, allow_interruptions cannot be False when using VoiceAgent.generate_reply(), " # noqa: E501
"disable turn_detection in the RealtimeModel and use VAD on the AgentTask/VoiceAgent instead" # noqa: E501
)
allow_interruptions = NOT_GIVEN

if ignore_agent_instructions:
logger.warning(
"generate_reply cannot ignore agent instructions in RealtimeModel" # noqa: E501
)

if self.llm is None:
raise RuntimeError("trying to generate reply without an LLM model")
Expand Down Expand Up @@ -823,10 +831,7 @@ def _generate_reply(
)

elif isinstance(self.llm, llm.LLM):
# instructions used inside generate_reply are "extra" instructions.
# this matches the behavior of the Realtime API:
# https://platform.openai.com/docs/api-reference/realtime-client-events/response/create
if instructions:
if instructions and not ignore_agent_instructions:
instructions = "\n".join([self._agent.instructions, instructions])

task = self._create_speech_task(
Expand Down
3 changes: 3 additions & 0 deletions livekit-agents/livekit/agents/voice/agent_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,7 @@ def generate_reply(
instructions: NotGivenOr[str] = NOT_GIVEN,
tool_choice: NotGivenOr[llm.ToolChoice] = NOT_GIVEN,
allow_interruptions: NotGivenOr[bool] = NOT_GIVEN,
ignore_agent_instructions: bool = False,
) -> SpeechHandle:
"""Generate a reply for the agent to speak to the user.

Expand Down Expand Up @@ -840,6 +841,7 @@ def generate_reply(
instructions=instructions,
tool_choice=tool_choice,
allow_interruptions=allow_interruptions,
ignore_agent_instructions=ignore_agent_instructions,
)
if run_state:
run_state._watch_handle(handle)
Expand All @@ -851,6 +853,7 @@ def generate_reply(
instructions=instructions,
tool_choice=tool_choice,
allow_interruptions=allow_interruptions,
ignore_agent_instructions=ignore_agent_instructions,
)
if run_state:
run_state._watch_handle(handle)
Expand Down
Loading