Skip to content

Conversation

@pblazej
Copy link
Contributor

@pblazej pblazej commented Jul 23, 2025

A basic test case:

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

⚠️ This PR does not contain any files in the .changes directory.

}

@objc
var agentStateString: String {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sort of breaks Obj-C contract, but IMO it's better than changing the schema for every single language, just for the sake of having Int raw value here...

case transcription
}

public enum AgentState: String, Codable, Sendable {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This public is a manual change, I don't think it's possible to expose a single one vs global "access-level": "public".

@pblazej pblazej force-pushed the blaze/attribute-generator branch from 6384ce0 to 4b81f5c Compare July 23, 2025 08:38

extension AgentState: CustomStringConvertible {
public var description: String {
rawValue.capitalized
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to remove this one, looks like leftover that could be handled by the frontend.

@pblazej pblazej requested a review from hiroshihorie July 23, 2025 10:45
_state.mutate { $0.attributes = attributes }
_state.mutate {
$0.attributes = attributes
$0.agentAttributes = attributes.transcoded(to: AgentAttributes.self)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically we could skip that for LocalParticipant, but it's not enforced anywhere else...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unused (but public), so I reverted that...

@pblazej pblazej merged commit 8de0f65 into main Jul 24, 2025
18 of 21 checks passed
@pblazej pblazej deleted the blaze/attribute-generator branch July 24, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants