Skip to content

Initial UniFFI C++ Bindgen - #1389

Open
alan-george-lk wants to merge 8 commits into
mainfrom
alan/feature-uniffi-cpp
Open

Initial UniFFI C++ Bindgen#1389
alan-george-lk wants to merge 8 commits into
mainfrom
alan/feature-uniffi-cpp

Conversation

@alan-george-lk

@alan-george-lk alan-george-lk commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Testing

@alan-george-lk
alan-george-lk force-pushed the alan/feature-uniffi-cpp branch 2 times, most recently from 54329d0 to a6646fa Compare September 8, 2026 22:05
@alan-george-lk alan-george-lk changed the title WIP: livekit-uniffi: C++ bingden support livekit-uniffi: add experimental C++ bindings smoke test Sep 8, 2026
@alan-george-lk
alan-george-lk force-pushed the alan/feature-uniffi-cpp branch from 3674716 to a2f8242 Compare September 9, 2026 15:11
@alan-george-lk
alan-george-lk force-pushed the alan/feature-uniffi-cpp branch from a2f8242 to e7bc2c4 Compare September 9, 2026 20:08
@alan-george-lk alan-george-lk changed the title livekit-uniffi: add experimental C++ bindings smoke test Initial UniFFI C++ Bindgen Sep 10, 2026
alan-george-lk
alan-george-lk commented Sep 10, 2026
View reviewed changes
Comment thread tools/bindgens/Cargo.toml Outdated
1egoman
1egoman approved these changes Sep 10, 2026
View reviewed changes
Comment thread tools/bindgens/Cargo.toml Outdated
Comment thread tools/bindgens/src/bin/uniffi-bindgen-cpp.rs Outdated
Comment on lines +29 to +30
const REPOSITORY: &str = "https://github.com/alan-george-lk/uniffi-bindgen-cpp.git";
const REVISION: &str = "7d54c1c56e0e4c46772ef4c2b5be3cb26396cbdb";

@1egoman 1egoman Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: If this will be long lived, it probably makes sense to move this under https://github.com/livekit and move to an explicit tag once it is stable?

@alan-george-lk alan-george-lk Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally on board with that, should we make that move now before this gets in? Might be good in general to have a fork sync come from LiveKit vs. my personal account anyways

@1egoman 1egoman Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea my vote would be to move it over to the livekit organization before merging this.

For reference I recently did something similar for the dart bindgen but moved back to the upstream (due to getting all the fixes upstreamed) before merging.

@xianshijing-lk xianshijing-lk Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, lets move it under livekit

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Changeset ✓

This PR includes a changeset covering all affected packages:

Package Bump
livekit-ffi patch

@alan-george-lk
alan-george-lk marked this pull request as ready for review September 14, 2026 16:08
@alan-george-lk alan-george-lk mentioned this pull request Sep 14, 2026
Open
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1egoman 1egoman 1egoman approved these changes
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@xianshijing-lk xianshijing-lk xianshijing-lk approved these changes
@ladvoc ladvoc Awaiting requested review from ladvoc ladvoc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-george-lk @1egoman @xianshijing-lk