fix: emit track-muted event for local tracks #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
kbalt
changed the title
kbalt
force-pushed
the
local-track-muted-event
branch
from
36905ef to
42bd9c5
Compare
kbalt
force-pushed
the
local-track-muted-event
branch
from
42bd9c5 to
d8bb6e2
Compare
kbalt
force-pushed
the
local-track-muted-event
branch
from
d8bb6e2 to
abc6ed5
Compare
kbalt
force-pushed
the
local-track-muted-event
branch
from
702f3ff to
bf56220
Compare
|
@davidzhao @typester any progress with this pr? :) |
kbalt
force-pushed
the
local-track-muted-event
branch
from
bf56220 to
c73496b
Compare
|
Running into the same issue. Any chance this can be moved forward? |
|
Hi @sandr01d, I will look into this. |
kbalt
force-pushed
the
local-track-muted-event
branch
from
c73496b to
6dd9315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no way to know when a track was muted by a moderator since track changes from the server were ignored.
This updates the TrackInfo of the local participant in a similar way, to how its done for remote participants.
While this seems to work, I'm not sure if this is the correct way to do this, since the comment in https://github.com/livekit/rust-sdks/blob/main/livekit/src/room/publication/remote.rs#L157 seems to imply that this should already work for local publications?