CI build for the morandi-rb gem

fix!: Remove Ruby 2.3 from CI matrix #191

Triggered via push September 12, 2024 14:24

knarewski

pushed 2e6bd65

fix-ci-and-setup

Status Failure

Total duration 2m 53s

Artifacts –

main.yml

on: push

ensures the dev environment image builds

2m 43s

rubocop

59s

Matrix: install dependencies and run tests

Annotations

13 warnings and 14 notices

install dependencies and run tests (2.7)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

install dependencies and run tests (2.7)

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

morandi.gemspec#L7

`metadata['rubygems_mfa_required']` must be set to `'true'`. [Gemspec/RequireMFA]

morandi.gemspec#L19

Do not set `test_files` in gemspec. [Gemspec/DeprecatedAttributeAssignment]

rubocop

ensures the dev environment image builds

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, docker/build-push-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

ensures the dev environment image builds

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, docker/build-push-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

ensures the dev environment image builds

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ensures the dev environment image builds

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ensures the dev environment image builds

lib/morandi/image_ops.rb#L17

Remove unnecessary empty `initialize` method. [Style/RedundantInitialize]

lib/morandi/image_ops.rb#L33

Use `val.clamp(min, max)` instead of `if/elsif/else`. [Style/ComparableClamp]

lib/morandi/image_ops.rb#L35

Use `[val, max].min` instead. [Style/MinMaxComparison]

lib/morandi/image_processor.rb#L116

Use `Comparable#clamp` instead. [Style/ComparableClamp]

lib/morandi/image_processor.rb#L124

Use `Comparable#clamp` instead. [Style/ComparableClamp]

lib/morandi/image_processor.rb#L178

Use string `','` as argument instead of regexp `/,/`. [Style/RedundantRegexpArgument]

lib/morandi/utils.rb#L42

Use `val.clamp(min, max)` instead of `if/elsif/else`. [Style/ComparableClamp]

lib/morandi/utils.rb#L44

Use `[val, max].min` instead. [Style/MinMaxComparison]

morandi.gemspec#L30