Refactor to reduce dependencies and increase spec coverage #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Suports conversion from pixbuf <> cairo image surface - Remove gtk2 dependency (it's deprecated and we were only using it to convert from pixbuf pixel layout to cairo image surface).
- Add initial pass at inline documentation for classes - Rename classes - Add redeye test - Fix rounded_rectangle support for "retro" borders - Ensure all files have >90% test coverage. - Remove unused classes and methods - Replace old "to_pixbuf" function that encodes/decodes PNG data with to_gdk_pixbuf that manipulates data inline.
geoffyoungs
changed the title
This was referenced Sep 12, 2024
|
Closing as a superset of this PR has been merged as #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the pixbufutils & redeye gems and bundles all the things in morandi_native.
It also moves replaces the gtk2 dependency with a gdk3 one (at the moment) but the intent is to remove the dependency on gtk2 entirely and just depend on gdk_pixbuf2, pango and cairo.
It fixes several bugs and increases code coverage to >90% on all files within the library.