refactor: improve test capability and coverage #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For smoother development experience. Example VSCode's Ruby LSP required Ruby 3.0+
…ent experience The file is being removed on CI, because different ruby versions may resolve differently See also: https://bundler.io/guides/faq.html#using-gemfiles-inside-gems
To make the spec more reliable, a new matcher has been introduced for visual image comparison A pumpkin photo was made by me and is distributed under MIT license
…ultiple lines for readability
MrLukeSmith
approved these changes
Oct 22, 2024
knarewski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I'm prototyping
libvips-based Morandi on a separate branch in hope of improving its memory profile and performanceProblem
The specs only check for presence of output files and do little to assess their content, requiring manual visual inspection
Solution
Introduce:
Notes
ensurekeyword available in blocks (2.5+)Gemfile.lockfor smoother Development experience (otherwise it's often required to runbundle installafter launching the container because of some gems getting outdated)Screenshots
tmp/reference-image-matches/morandi_spec-rb-512/reference.jpg)tmp/reference-image-matches/morandi_spec-rb-512/tested.jpg) after disabling colour profile conversion (there's clear colour difference caused by stripping colour profile information without proper conversion)tmp/reference-image-matches/morandi_spec-rb-512/diff.jpgafter disabling colour profile conversion (red-ish pixels indicate colour mismatch)