Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicitly raise error when trying to use unsupported operation #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knarewski
Copy link
Contributor

@knarewski knarewski commented Dec 11, 2024

Background

GdkPixbuf-based image processing can take over 1GB of memory for processing a single high-resolution photo. We've decided to introduce another processor, hoping that it'll improve Morandi's memory profile and performance.

At the moment a subset of operations has been implemented using vips. Whether the others will be added or deprecated remains to be decided.

Problems

If someone decides to give vips processor a go, but uses unsupported operations, these will currently be silently omitted.

Solution

Explicitly raise error when unsupported operation is requested. User will be able to detect it and act accordingly, eg try to re-render using pixbuf processor.

Notes

Also fixed a little typo which was raising a warning when generating docs (@options -> @option)

That should prevent accidental, silent omission of a desired transformation
@knarewski knarewski requested a review from a team December 11, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant