feat: explicitly raise error when trying to use unsupported operation #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
GdkPixbuf-based image processing can take over 1GB of memory for processing a single high-resolution photo. We've decided to introduce another processor, hoping that it'll improve Morandi's memory profile and performance.
At the moment a subset of operations has been implemented using
vips
. Whether the others will be added or deprecated remains to be decided.Problems
If someone decides to give
vips
processor a go, but uses unsupported operations, these will currently be silently omitted.Solution
Explicitly raise error when unsupported operation is requested. User will be able to detect it and act accordingly, eg try to re-render using pixbuf processor.
Notes
Also fixed a little typo which was raising a warning when generating docs (
@options
->@option
)