Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livepeer-w3 to catalyst docker image #396

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

leszko
Copy link
Collaborator

@leszko leszko commented Feb 7, 2023

We need a nodejs script in order to upload files into web3.storage.

It increases the Docker images size 2.22GB => 2.46GB

For the context, please check this PR: livepeer/go-tools#17

fix #373

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #396 (37c783d) into main (f6ece45) will decrease coverage by 0.53305%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #396         +/-   ##
===================================================
- Coverage   34.32836%   33.79531%   -0.53305%     
===================================================
  Files              4           4                 
  Lines            938         938                 
===================================================
- Hits             322         317          -5     
- Misses           572         579          +7     
+ Partials          44          42          -2     
Impacted Files Coverage Δ
...yst-node/handlers/access-control/access-control.go 57.06215% <0.00000%> (-2.82486%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ece45...37c783d. Read the comment docs.

Impacted Files Coverage Δ
...yst-node/handlers/access-control/access-control.go 57.06215% <0.00000%> (-2.82486%) ⬇️

Copy link
Member

@hjpotter92 hjpotter92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one minor suggestion, if possible; could go-tools generate a package similar to how studio releases livepeer-api and livepeer-www binaries with node dependencies bundled? it'd then simply be a matter of adding a service in manifest which can use the strip build target from this docker manifest.

@leszko
Copy link
Collaborator Author

leszko commented Feb 7, 2023

lgtm. one minor suggestion, if possible; could go-tools generate a package similar to how studio releases livepeer-api and livepeer-www binaries with node dependencies bundled? it'd then simply be a matter of adding a service in manifest which can use the strip build target from this docker manifest.

That would be nice. Though I'm not sure how much work it is to create releases and if it's worth it. For now, I've created a GH Issue: livepeer/go-tools#18

@leszko leszko merged commit 7738726 into main Feb 7, 2023
@leszko leszko deleted the rafal/web3.storage branch February 7, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Catalyst Docker image with w3 dependencies
3 participants