please oh please, do not merge: CPU retry hack #1419
Closed
+48
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iameli you can create draft pull request - it can't be merged |
It doesn't work without this. It's somewhat surprising that it works with this.
darkdarkdragon
force-pushed
the
eli/cpu-retry-hack
branch
from
e80acc4 to
6a30940
Compare
|
Superseded by #1502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather inelegant workaround for livepeer/lpms#168.
CPU transcoding of single-frame segments appears to work in versions of go-livepeer prior to ed8e8c4. So, this change enables the transcoder server as
node.BackupTranscoderin-orchestrator -transcodermode. In production, an old, slightly tweaked version of go-livepeer attaches to that transcode server. When a segment is ingested, transcoding is first attempted using the local Nvidia transcoder. If that results in aZeroSegmentserror, it falls back to the remote transcoder.Let's do something better than this real soon 😃 On the other hand...
Nice.