Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating a release with bundled livepeer-w3 after a tag push #18

Open
leszko opened this issue Feb 7, 2023 · 2 comments
Open

Comments

@leszko
Copy link
Contributor

leszko commented Feb 7, 2023

A comment from @hjpotter92

could go-tools generate a package similar to how studio releases livepeer-api and livepeer-www binaries with node dependencies bundled? it'd then simply be a matter of adding a service in manifest which can use the strip build target from this docker manifest.

If we follow that way, then we could re-use the manifest.go tool from livepeer/catalyst to build Docker images.

@hjpotter92
Copy link
Member

in livepeer/studio; we used pkg to create an executable binary. you can check relevant package.json script defined here: https://github.com/livepeer/studio/blob/master/packages/api/package.json#L39-L40

@leszko
Copy link
Contributor Author

leszko commented Feb 15, 2023

We can hold off on doing this, maybe web3.storage will merge the related PR to their repo, then we would not need to main own tool at all.

Related GH Issue: storacha/w3cli#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants