Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second part of refactoring changes #348

Closed
wants to merge 11 commits into from
Closed

Second part of refactoring changes #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
825d761
Old transcode() function removed
Jun 15, 2022
d585fea
Encoder creation changes
Jun 23, 2022
0c60e3d
Encoder creation logic moved
Jun 23, 2022
7cff866
Muxer streams refactoring
Jun 28, 2022
1c44471
Simpler input/output management
Jun 28, 2022
ca07ecc
Input and init logic changes
Jun 30, 2022
c3b385a
Removed transcode_init
Jul 4, 2022
277b810
Adopting free_input everywhere
Jul 4, 2022
3b2605c
Single lpms_transcode_new function
Jul 5, 2022
663ea72
Muxer trailer and output changes
Jul 5, 2022
c712137
Demuxer reopening fixes
MikeIndiaAlpha Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 2 additions & 32 deletions ffmpeg/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func TestAPI_SkippedSegment(t *testing.T) {
}

func TestTranscoderAPI_InvalidFile(t *testing.T) {
// Test the following file open results on input: fail, success, fail, success
// Test the following file open results on input: success, fail, success

tc := NewTranscoder()
defer tc.StopTranscoder()
Expand All @@ -100,18 +100,9 @@ func TestTranscoderAPI_InvalidFile(t *testing.T) {
Muxer: ComponentOptions{Name: "null"},
}}

// fail # 1
in.Fname = "none"
_, err := tc.Transcode(in, out)
if err == nil || err.Error() != "TranscoderInvalidVideo" {
// Early codec check didn't find video in missing input file so we get `TranscoderInvalidVideo`
// instead of `No such file or directory`
t.Error("Expected 'TranscoderInvalidVideo', got ", err)
}

// success # 1
in.Fname = "../transcoder/test.ts"
_, err = tc.Transcode(in, out)
_, err := tc.Transcode(in, out)
if err != nil {
t.Error(err)
}
Expand Down Expand Up @@ -1217,27 +1208,6 @@ func audioOnlySegment(t *testing.T, accel Acceleration) {
}
}
tc.StopTranscoder()

// Test encoding with audio-only segment in start of stream
tc = NewTranscoder()
defer tc.StopTranscoder()
for i := 2; i < 4; i++ {
in := &TranscodeOptionsIn{
Fname: fmt.Sprintf("%s/test%d.ts", dir, i),
Accel: accel,
}
out := []TranscodeOptions{{
Oname: fmt.Sprintf("%s/out2_%d.ts", dir, i),
Profile: prof,
Accel: accel,
}}
_, err := tc.Transcode(in, out)
if i == 2 && (err == nil || err.Error() != "TranscoderInvalidVideo") {
t.Errorf("Expected to fail for audio-only segment but did not, instead got err=%v", err)
} else if i != 2 && err != nil {
t.Error(err)
}
}
}

func TestTranscoder_AudioOnly(t *testing.T) {
Expand Down
Loading