fix(search): Fix search suggestions not displaying#1
Open
genspark-ai-developer[bot] wants to merge 1 commit intomainfrom
Open
fix(search): Fix search suggestions not displaying#1genspark-ai-developer[bot] wants to merge 1 commit intomainfrom
genspark-ai-developer[bot] wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
force-pushed
the
build_runner
branch
28 times, most recently
from
ee12379 to
0190834
Compare
github-actions
bot
force-pushed
the
build_runner
branch
2 times, most recently
from
ac24bf6 to
fdeb352
Compare
github-actions
bot
force-pushed
the
build_runner
branch
20 times, most recently
from
cf43446 to
247dbdc
Compare
github-actions
bot
force-pushed
the
build_runner
branch
from
247dbdc to
eb5a96f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getSuggests()had inverted logic, returning empty array when text changedSolution
_suggestslist instead of empty array_searchController.openView()after loading to refresh suggestion listRoot Cause
The method returned
[]immediately, then loaded suggestions asynchronously, but had no mechanism to refresh the UI after loading.Testing