Skip to content

Conversation

@keitwb
Copy link

@keitwb keitwb commented Oct 29, 2025

The previous definitions only allowed for a single level of nesting of lists/dicts and was not truly recursive. Tool call inputs with more complex inputs would fail validation and throw an exception.

What does this PR do?

Makes the ToolCall argument type fully recursive.

Test Plan

Tried it repeatedly with a complex tool call with deeply nested dicts and it worked without issue with this change.

@meta-cla
Copy link

meta-cla bot commented Oct 29, 2025

Hi @keitwb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

The previous definitions only allowed for a single level of nesting of lists/dicts
and was not truly recursive. Tool call inputs with more complex inputs would fail
validation and throw an exception.
@keitwb keitwb force-pushed the toolcall-arg-recursive-type branch from a6f8753 to acf8354 Compare October 29, 2025 13:47
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 29, 2025
@keitwb keitwb changed the title Make ToolCall arguments fully recursive fix: Make ToolCall arguments fully recursive Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant