Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Activity Description opening downwards in Journal #1407 #1667

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

AdityaKrSingh26
Copy link

@AdityaKrSingh26 AdityaKrSingh26 commented Oct 24, 2024

For the last icon the popup appears up instead of downwards . Popup remains on the same page instead of extending page downwards. (issue : #1407)
image

@llaske
Copy link
Owner

llaske commented Oct 26, 2024

Nice. But it only fix partially the problem in the Journal: the popup is still under the footer.

capture.webm

@AdityaKrSingh26
Copy link
Author

okay, i will fix this

@AdityaKrSingh26
Copy link
Author

AdityaKrSingh26 commented Oct 29, 2024

@llaske i have opened a new pr to the issue i have fixed the issue you mentioned could you please review it

commit : 5f77084

sugar.mp4

@llaske
Copy link
Owner

llaske commented Nov 3, 2024

The issue I've mentioned is in the Journal view not in the listview.
Your new fix doesn't change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants