Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

56 utilisation de la colonne normalized area pour les ratios c12c13 skyline #61

Conversation

rkouakou06
Copy link
Collaborator

J'ai modifié la méthode "generate_ratios" (j'ai mis en commentaire juste en dessous la précédente méthode).

PS: il y a toujours les warning liés au "downcasting" :

FutureWarning: Downcasting behavior in `replace` is deprecated and will be removed in a future version. To retain the old behavior, explicitly call `result.infer_objects(copy=False)`. To opt-in to the future behavior, set `pd.set_option('future.no_silent_downcasting', True)`
  self.data["Area"] = self.data["Area"].replace("N/F", 0).infer_objects(copy=False)

Pourtant j'ai ajouté infer_object(), du coup je capte pas trop

Copy link
Owner

@llegregam llegregam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste changer le if else et logger les ratios ayant beugé et c'est bueno

@llegregam
Copy link
Owner

J'ai eu un petit beug sur un fichier à moi ^^'
image

@rkouakou06
Copy link
Collaborator Author

@llegregam
Copy link
Owner

Oui j'ai checkout la branche et j'ai installé la version en local

@llegregam llegregam merged commit 58aed0b into master Sep 9, 2024
0 of 15 checks passed
@llegregam llegregam deleted the 56-utilisation-de-la-colonne-normalized-area-pour-les-ratios-c12c13-skyline branch September 9, 2024 14:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilisation de la colonne "Normalized Area" pour les ratios C12/C13 (Skyline)
2 participants