DoRA support #608
Closed
DoRA support #608
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
I've checked this locally by pulling the request branch and it works fine, will this be merged at any point? |
abel1502
approved these changes
Apr 13, 2024
|
Hi, this matches ComfyUI but differs from sdwebui. The generated image changes at scale 0. I opened a patch to ComfyUI to try to standardize on sdwebui's approach: |
|
@catboxanon can you change this pr to dev2 and could @huchenlei merge? seems like main is dead for now |
Panchovix
pushed a commit
to Panchovix/stable-diffusion-webui-reForge
that referenced
this pull request
Jun 30, 2024
Applies lllyasviel#608 PR.
Bluenochian
approved these changes
Jul 8, 2024
Open
lllyasviel
approved these changes
Aug 1, 2024
|
hi we are going to close PRs before forge's recent major revision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title. Adapted from comfyanonymous/ComfyUI@ae77590
Semi-related: I don't think my question I originally asked in #80 was addressed well. Are we planning to sync upstream of both the webui and ComfyUI? Or, only the webui, and to cherry-pick certain updates from ComfyUI such as this one?