Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Hrfix and CN #630

Closed
wants to merge 11 commits into from
Closed

Conversation

jetjodh
Copy link

@jetjodh jetjodh commented Apr 2, 2024

Description

Checklist:

@jetjodh jetjodh requested a review from lllyasviel as a code owner April 2, 2024 15:49
@jetjodh jetjodh changed the base branch from main to dev2 May 22, 2024 20:55
@jetjodh
Copy link
Author

jetjodh commented May 22, 2024

@huchenlei can you review this?

@huchenlei
Copy link
Contributor

Can you add an API test under https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/extensions-builtin/sd_forge_controlnet/tests/web_api/ ?

It can be similar to the test added in #754 . Although we cannot enable the test in the CQ, at least we can have a stable way to verify this is working locally and compare test results across versions.

@jetjodh
Copy link
Author

jetjodh commented May 23, 2024

Can you add an API test under https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/extensions-builtin/sd_forge_controlnet/tests/web_api/ ?

It can be similar to the test added in #754 . Although we cannot enable the test in the CQ, at least we can have a stable way to verify this is working locally and compare test results across versions.
@huchenlei
Added a test (hopefully works)

@adde88
Copy link

adde88 commented Jun 22, 2024

I tested this patch today several times, on both 1.5, and SDXL models, with HRfix and CN. The errors are not there anymore, and it seems to work. Thought i'd give some feedback :)

Panchovix pushed a commit to Panchovix/stable-diffusion-webui-reForge that referenced this pull request Jul 13, 2024
@lllyasviel lllyasviel deleted the branch lllyasviel:on_hold August 1, 2024 19:51
@lllyasviel lllyasviel closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ControlNet and Kohya HRFix interop support
5 participants