-
Notifications
You must be signed in to change notification settings - Fork 35
Refactor project structure to python proj #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…bled for setup scripts)
|
Hey @maugustosilva @Vezio, this is sadly a huge pr :( Although I tried my best to validate changes locally, I must not have covered many things due to environment limits. Testing this PR in your environment should be required as well. Please let me know what issues, and enjoy the mess : D In general, this PR includes pdm as the package manager. Ruff is configured as the formatter and linter. The main source files are moved to the folder
Most of the py file changes are from the formatter and linter and are thus safe to skip in your review. Quick check cmds pip install pdm && pdm install && pdm run $SHELL
pdm run format-check
pdm run lint-check
pdm run test
pdm run pre-commit run --all Cheers. |
|
@pancak3 Oh well :-). First of all thanks for the contributions, but with 165 files changed, I need to ask about the possibility of splitting it on smaller PRs. |
|
@pancak3 I'd propose the following integration path:
Thank you for such great efforts! |
That sounds pretty reasonable to me. I will check out the first todo item within the week and others after. Got some research ddls to catch this month. Thanks! @Vezio @maugustosilva |
|
@pancak3 awesome thanks! I sense there will be a LOT of contributions this week and a bit of refactoring, so it will probably be good timing for your research you have going on so the code takes a breather 😄 |
/resolve #290