Skip to content

Add function to get scenario counts #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2025
Merged

Add function to get scenario counts #472

merged 2 commits into from
Oct 24, 2025

Conversation

@namasl
Copy link
Collaborator

@namasl namasl commented Oct 24, 2025

No description provided.

@namasl namasl requested a review from jgchn October 24, 2025 13:54
jgchn
jgchn reviewed Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@jgchn jgchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant, as part of the scenario df that is returned in get_scenario(), include a count column. Sorry if that wasn't clear. But the table that is printed in print_scenarios is nice, and I was hoping to have get_scenarios() or another function to match that.

@namasl namasl merged commit bd31648 into llm-d:main Oct 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgchn jgchn jgchn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@namasl @jgchn