Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

Conversation

@yankay
Copy link
Contributor

@yankay yankay commented Jul 20, 2025

Problem

When using sudo curl in the installation script, HTTP proxy environment variables (such as http_proxy, https_proxy, no_proxy) are not inherited by the curl process running under sudo. This causes network requests to fail in proxy environments.

Solution

Modified the yq installation process in quickstart/install-deps.sh:
• Replaced sudo curl -sLo /usr/local/bin/yq with curl -sLo yq followed by sudo mv yq /usr/local/bin/yq
• Added a verification step to ensure yq is correctly installed (to address potential issues like an incorrect version being installed).

@yankay
Copy link
Contributor Author

yankay commented Jul 21, 2025

HI @nerdalert
Would you please help to review it

Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the enhancement. Btw, wanted to give you a heads up we are migrating to a decomposed deployer here https://github.com/llm-d-incubation/llm-d-infra in the next few days in a release. Don't hesitate to ping here or in Slack with any questions/concerns. Ty.

@nerdalert nerdalert merged commit 35ec271 into llm-d:main Jul 21, 2025
3 checks passed
@yankay
Copy link
Contributor Author

yankay commented Jul 22, 2025

LGTM, thanks for the enhancement. Btw, wanted to give you a heads up we are migrating to a decomposed deployer here https://github.com/llm-d-incubation/llm-d-infra in the next few days in a release. Don't hesitate to ping here or in Slack with any questions/concerns. Ty.

Thanks @nerdalert

Would you help invite me to join the Slack group for llm-d? My email is [email protected]

@nerdalert
Copy link
Member

@yankay great! Grab the inviter link here https://github.com/llm-d/llm-d?tab=readme-ov-file#contribute

we also have a Thursday community call in the calendar on the same page. Chat soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants