Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

Conversation

@nicole-lihui
Copy link
Contributor

update llm-d-model-service tag version to v0.0.15
fix llm-d/llm-d-model-service#223

optimization makefile

  • makefile supported auto bump-image-tags
  • opt bump-modelservice-crd specify version & --depth=1

@nicole-lihui nicole-lihui force-pushed the build-crd branch 2 times, most recently from 84fe973 to 9e5fa55 Compare July 15, 2025 06:27
@nicole-lihui nicole-lihui changed the title update llm-d-model-service version to v0.0.15 bump llm-d-model-service version to v0.0.15 Jul 15, 2025
@nerdalert
Copy link
Member

nerdalert commented Jul 15, 2025

Hi @nicole-lihui appreciate the PR. I'm happy to close #342 for this. We are cutting a release this week and decomposing the charts and bump still need to keep this set of charts alive for now. Can you bump the Chart for CI again pls https://github.com/llm-d/llm-d-deployer/blob/main/charts/llm-d/Chart.yaml#L4

Odds are that version will get stomped on as a release is cut, so apologies now. Just wanted to warn you upfront it might be annoying since it's pretty much a release versioning cut 😅 Will test end to end with this today.

@nicole-lihui
Copy link
Contributor Author

🙌 Chart version bumped! Let me know if there's anything else needed.

Thanks for the review @nerdalert

@nicole-lihui nicole-lihui changed the title bump llm-d-model-service version to v0.0.15 bump llm-d-x images to latest tags Jul 17, 2025
@nicole-lihui nicole-lihui changed the title bump llm-d-x images to latest tags bump llm-d-x images to latest tags & improve ci Jul 17, 2025
nerdalert
nerdalert previously approved these changes Jul 18, 2025
Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nicole-lihui I tested this and it LGTM. Ty! cc/ @Gregory-Pereira at your convenience take a peek.

@nicole-lihui
Copy link
Contributor Author

Hi @nicole-lihui I tested this and it LGTM. Ty! cc/ @Gregory-Pereira at your convenience take a peek.

Hi @nerdalert,
this chart is ok right, but I noticed there's an issue with the workflow.

The "Test Latest Release" job doesn't actually pick up the new values when running helm upgrade.

image image

I try use helm upgrade flags : --reset-values , this is incorrect methods

@nicole-lihui nicole-lihui requested a review from nerdalert July 18, 2025 06:42
@nicole-lihui
Copy link
Contributor Author

nicole-lihui commented Jul 18, 2025

😟 ct default use --reuse-values

helm/chart-testing#525

Is there a way to work around this behavior in the workflow? I’m not quite sure about this part.

@nicole-lihui
Copy link
Contributor Author

ct fixed in helm/chart-testing#742, version is v3.13.0

but helm action not released

@nerdalert
Copy link
Member

Hi @nicole-lihui I've done some basic testing with base and p/d deployments and things looked good. I'd like to bump this Monday when we cut a release. Also wanted to make sure you have seen this which we are migrating to as this deprecates at some point for the decomposed approach here https://github.com/llm-d-incubation/llm-d-infra Ty!

@nicole-lihui
Copy link
Contributor Author

https://github.com/llm-d-incubation/llm-d-infra

@nerdalert Appreciate you sharing the roadmap of llm-d deployment mode! I like this decompose setup in llm-d-infra -- the current large values can be a bit messy.

I'll stay tuned and would love to keep contributing!

Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the patience and effort here @nicole-lihui!

@nerdalert nerdalert merged commit 6f5b363 into llm-d:main Jul 22, 2025
4 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModelService doesn't create HTTPRoute

2 participants