Conversation
Member
Author
|
@YohannDudouit , I'm thinking the shared memory arena that we talked about could look be implemented something like this? At the moment I'm not sure how we can differentiate between static or dynamically allocated shared memory. What do you think? |
Member
Author
|
@tomstitt , adding you in the loop since I think we talked about this as well. |
|
|
||
| // TODO handle alignment | ||
| template<typename T> | ||
| RAJA_HOST_DEVICE T* getArenaMemory(size_t bytes) |
There was a problem hiding this comment.
I don't think bytes reflects well how this is used, it seems to be a number of values, not a number of bytes.
Co-authored-by: Yohann <yohann.dudouit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the concept of a memory arena of launch. The underlying idea is to allow users to allocate static shared memory (or could be an external memory type?) and manage it through a bump style allocator.
This PR is a work in progress.