Open
Conversation
rhornung67
approved these changes
Dec 15, 2025
Member
rhornung67
left a comment
rhornung67
left a comment
There was a problem hiding this comment.
@johnbowen42 we cannot force C++20 yet since it that would break some of our WSC user codes.
rhornung67
reviewed
Dec 15, 2025
Member
rhornung67
left a comment
rhornung67
left a comment
There was a problem hiding this comment.
Let's hold off on merging this and reassess after the release.
rhornung67
requested changes
Dec 15, 2025
Member
rhornung67
left a comment
rhornung67
left a comment
There was a problem hiding this comment.
Trying to dismiss approval
Contributor
|
Umpire has a similar PR - we can reassess after the holidays on when we want to start enforcing c++20 minimum requirement |
johnbowen42
force-pushed
the
feature/bowen/cpp20
branch
from
f906f76 to
76ec8df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the minimum C++ version in CMake and build scripts to C++20. We probably want to hold off on merging this change until after the upcoming release is cut.