Open
Conversation
Member
|
@johnbowen42 We're going to have problems with this because MSVC does not support some OpenMP standard stuff we use; e.g., it doesn't know about the |
johnbowen42
force-pushed
the
ci/bowen/add-openmp-windows
branch
from
99014ab to
a86ef0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw some failures in axoms CI as a result of (1) C++17 changes to OpenMP backends, (2) Windows build, (3) openmp enabled, so I am enabling openmp here to troubleshoot and hopefully add coverage